Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: git_cl/git_cl.py

Issue 6686060: minor cleanup w/ chases's feedback from CL 6665018. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl/git_cl.py
diff --git a/git_cl/git_cl.py b/git_cl/git_cl.py
index 8300cc38404b6bb1f20adf97a4f0c40e9d509de7..aaa2670e43517c1603cd2431dd10b1999e809f19 100644
--- a/git_cl/git_cl.py
+++ b/git_cl/git_cl.py
@@ -741,10 +741,10 @@ def RunHook(committing, upstream_branch, rietveld_server, tbr, may_prompt):
root = RunCommand(['git', 'rev-parse', '--show-cdup']).strip()
if not root:
- root = "."
+ root = '.'
absroot = os.path.abspath(root)
if not root:
- raise Exception("Could not get root directory.")
+ raise Exception('Could not get root directory.')
# We use the sha1 of HEAD as a name of this change.
name = RunCommand(['git', 'rev-parse', 'HEAD']).strip()
@@ -760,7 +760,7 @@ def RunHook(committing, upstream_branch, rietveld_server, tbr, may_prompt):
# up to the branch point, as git cl upload will prefill the description
# with these log messages.
description = RunCommand(['git', 'log', '--pretty=format:%s%n%n%b',
- '%s...' % (upstream_branch)]).strip()
+ '%s...' % (upstream_branch)]).strip()
change = presubmit_support.GitChange(name, description, absroot, files,
issue, patchset)
@@ -770,7 +770,7 @@ def RunHook(committing, upstream_branch, rietveld_server, tbr, may_prompt):
files = [f.LocalPath() for f in change.AffectedFiles()]
watchers = watchlist.GetWatchersForPaths(files)
RunCommand(['git', 'config', '--replace-all',
- 'rietveld.extracc', ','.join(watchers)])
+ 'rietveld.extracc', ','.join(watchers)])
output = StringIO.StringIO()
should_continue = presubmit_support.DoPresubmitChecks(change, committing,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698