Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: gcl.py

Issue 6686046: Revert part of 77946 and 77978 so things work against when EDITOR is set to... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_cl/git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 78021)
+++ gcl.py (working copy)
@@ -1064,13 +1064,10 @@
os.close(handle)
# Open up the default editor in the system to get the CL description.
- cmd = [GetEditor(), filename]
- if sys.platform == 'win32' and os.environ.get('TERM') == 'msys':
- # Msysgit requires the usage of 'env' to be present.
- cmd.insert(0, 'env')
+ result = None
try:
if not silent:
- subprocess.check_call(cmd)
+ os.system(GetEditor() + " " + filename)
result = gclient_utils.FileRead(filename, 'r')
finally:
os.remove(filename)
« no previous file with comments | « no previous file | git_cl/git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698