Issue 6686004: Do not modify the input image while signing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6686004: Do not modify the input image while signing. (Closed)

Created:
9 years, 9 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Hung-Te

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Do not modify the input image while signing. Change-Id: I17e1a5abcc4f2fab970a587b338594a7d51ecb2e BUG=chromium-os:13026 TEST=manually tested all signing modes(usb, ssd, recovery, install), input image was not modified in each case. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=276f846

Patch Set 1 #

Patch Set 2 : fix typos #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -33 lines)			Patch
	M	scripts/image_signing/sign_official_build.sh	View	1	7 chunks	+61 lines, -33 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages