Issue 6685101: Allow file in --from arg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6685101: Allow file in --from arg (Closed)

Created:
9 years, 9 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Allow file in --from arg * mount_gpt_image.sh * image_to_usb.sh BUG=chromium-os:12367 TEST=mount w/ --from file, check failure with file and -i, block dev and -i, check unmount, check image_to_usb, check --from dir -i file Change-Id: I8d8604ee7ee83513edd687b0a66cda44f64db1f8 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f9c49ad

Patch Set 1 #

Patch Set 2 : comments #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -2 lines)			Patch
	M	image_to_usb.sh	View		2 chunks	+10 lines, -1 line	0 comments	Download
	M	mount_gpt_image.sh	View	1	2 chunks	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sosa

--unmount doesn't require --from or --image to be set. Won't this break that?

9 years, 9 months ago (2011-03-18 23:00:47 UTC) #3

Nick Sanders

This only checks that --image isn't on the commandline if --image would also be overridden ...

9 years, 9 months ago (2011-03-21 06:20:27 UTC) #4

sosa

9 years, 9 months ago (2011-03-21 16:45:44 UTC) #5

You're right, I see that now.  LGTM

On Sun, Mar 20, 2011 at 11:20 PM,  <nsanders@chromium.org> wrote:
> This only checks that --image isn't on the commandline if --image would also
> be
> overridden  implicitly by --from. So in the unmount case where neither is
> specified, we're OK.
>
> I've updated the TEST field with a less handwavy and more descriptive entry
> regarding what I actually ran.
>
>
>
> http://codereview.chromium.org/6685101/
>

Expand Messages | Collapse Messages