Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3237)

Unified Diff: chrome/test/pyautolib/pyautolib.h

Issue 6685099: Removing command_execution_timeout_ms in favor of action_max_timeout_ms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/pyautolib/pyautolib.h
===================================================================
--- chrome/test/pyautolib/pyautolib.h (revision 79305)
+++ chrome/test/pyautolib/pyautolib.h (working copy)
@@ -168,6 +168,9 @@
// Use -ve window_index for automation calls not targetted at a browser
// window. Example: Login call for chromeos.
std::string _SendJSONRequest(int window_index, const std::string& request);
+ std::string _SendJSONRequest(int window_index,
+ const std::string& request,
+ int timeout);
// Execute javascript in a given tab, and return the response. This is
// a low-level method intended for use mostly by GetDOMValue(). Note that
@@ -202,10 +205,6 @@
return TestTimeouts::action_max_timeout_ms();
}
- int command_execution_timeout_ms() const {
- return TestTimeouts::command_execution_timeout_ms();
- }
-
private:
// Enables PostTask to main thread.
// Should be shared across multiple instances of PyUITestBase so that this

Powered by Google App Engine
This is Rietveld 408576698