Removing command_execution_timeout_ms in favor of action_max_timeout_ms.

chrome/test/automation/browser_proxy.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/automation/browser_proxy.h"
 
 #include <algorithm>
 
 #include "base/json/json_reader.h"
 #include "base/logging.h"
+#include "base/test/test_timeouts.h"
 #include "base/threading/platform_thread.h"
 #include "base/time.h"
 #include "chrome/common/automation_constants.h"
 #include "chrome/common/automation_messages.h"
 #include "chrome/test/automation/autocomplete_edit_proxy.h"
 #include "chrome/test/automation/automation_proxy.h"
 #include "chrome/test/automation/tab_proxy.h"
 #include "chrome/test/automation/window_proxy.h"
 #include "ui/gfx/point.h"
 
@@ skipping 548 matching lines @@
   if (!is_valid())
     return false;
 
   bool result = false;
   if (!sender_->Send(new AutomationMsg_WaitForPopupMenuToOpen(&result)))
     return false;
   return result;
 }
 
 bool BrowserProxy::SendJSONRequest(const std::string& request,
+                                   int timeout_ms,
                                    std::string* response) {
   if (!is_valid())
     return false;
 
   bool result = false;
   if (!sender_->Send(new AutomationMsg_SendJSONRequest(handle_,
                                                        request,
                                                        response,
-                                                       &result)))
+                                                       &result),
+                                                       timeout_ms))
     return false;
   return result;
 }
 
 bool BrowserProxy::GetInitialLoadTimes(float* min_start_time,
                                        float* max_stop_time,
                                        std::vector<float>* stop_times) {
   std::string json_response;
   const char* kJSONCommand = "{\"command\": \"GetInitialLoadTimes\"}";
 
   *max_stop_time = 0;
   *min_start_time = -1;
-  if (!SendJSONRequest(kJSONCommand, &json_response)) {
+  if (!SendJSONRequest(kJSONCommand,
+        TestTimeouts::action_max_timeout_ms(), &json_response)) {

[Nirnimesh, 2011/03/31 18:37:56]

the indentation is weird. Please either indent by 4 spaces wrt ( on previous
line, or align everything under kJSONCommand

[Huyen, 2011/03/31 18:52:19]

Done.

     // Older browser versions do not support GetInitialLoadTimes.
     // Fail gracefully and do not record them in this case.
     return false;
   }
   std::string error;
   base::JSONReader reader;
   scoped_ptr<Value> values(reader.ReadAndReturnError(json_response, true,
                                                      NULL, &error));
   if (!error.empty() || values->GetType() != Value::TYPE_DICTIONARY)
     return false;
@@ skipping 30 matching lines @@
     if (i == 0)
       *min_start_time = start_ms;
 
     *min_start_time = std::min(start_ms, *min_start_time);
     *max_stop_time = std::max(stop_ms, *max_stop_time);
     stop_times->push_back(stop_ms);
   }
   std::sort(stop_times->begin(), stop_times->end());
   return true;
 }