Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 6685097: Print LoadKernel() debug data from VbSharedData (Closed)

Created:
9 years, 9 months ago by Randall Spangler
Modified:
9 years, 7 months ago
Reviewers:
stefanreinauer
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Print LoadKernel() debug data from VbSharedData Change-Id: I60cf9c4dd07e83b1ed1a5bac8a3ce8c2a54df45b R=reinauer@chromium.org BUG=chrome-os-partner:2748 TEST=manually check output of 'crossystem vdat_lkdebug' Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7141571

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -15 lines) Patch
M firmware/include/vboot_struct.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M host/lib/crossystem.c View 5 chunks +124 lines, -10 lines 0 comments Download
M utility/crossystem_main.c View 6 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Randall Spangler
9 years, 9 months ago (2011-03-18 21:27:05 UTC) #1
stefanreinauer
LGTM http://codereview.chromium.org/6685097/diff/1/firmware/include/vboot_struct.h File firmware/include/vboot_struct.h (right): http://codereview.chromium.org/6685097/diff/1/firmware/include/vboot_struct.h#newcode206 firmware/include/vboot_struct.h:206: uint8_t reserved0; /* Reserved */ maybe a comment ...
9 years, 9 months ago (2011-03-18 21:39:46 UTC) #2
stefanreinauer
9 years, 9 months ago (2011-03-18 21:51:52 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698