Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: src/x64/debug-x64.cc

Issue 6685088: Merge isolates to bleeding_edge. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/cpu-x64.cc ('k') | src/x64/disasm-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 return Debug::IsDebugBreakAtReturn(rinfo()); 42 return Debug::IsDebugBreakAtReturn(rinfo());
43 } 43 }
44 44
45 45
46 // Patch the JS frame exit code with a debug break call. See 46 // Patch the JS frame exit code with a debug break call. See
47 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-x64.cc 47 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-x64.cc
48 // for the precise return instructions sequence. 48 // for the precise return instructions sequence.
49 void BreakLocationIterator::SetDebugBreakAtReturn() { 49 void BreakLocationIterator::SetDebugBreakAtReturn() {
50 ASSERT(Assembler::kJSReturnSequenceLength >= 50 ASSERT(Assembler::kJSReturnSequenceLength >=
51 Assembler::kCallInstructionLength); 51 Assembler::kCallInstructionLength);
52 rinfo()->PatchCodeWithCall(Debug::debug_break_return()->entry(), 52 rinfo()->PatchCodeWithCall(
53 Isolate::Current()->debug()->debug_break_return()->entry(),
53 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength); 54 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength);
54 } 55 }
55 56
56 57
57 // Restore the JS frame exit code. 58 // Restore the JS frame exit code.
58 void BreakLocationIterator::ClearDebugBreakAtReturn() { 59 void BreakLocationIterator::ClearDebugBreakAtReturn() {
59 rinfo()->PatchCode(original_rinfo()->pc(), 60 rinfo()->PatchCode(original_rinfo()->pc(),
60 Assembler::kJSReturnSequenceLength); 61 Assembler::kJSReturnSequenceLength);
61 } 62 }
62 63
63 64
64 // A debug break in the frame exit code is identified by the JS frame exit code 65 // A debug break in the frame exit code is identified by the JS frame exit code
65 // having been patched with a call instruction. 66 // having been patched with a call instruction.
66 bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo* rinfo) { 67 bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo* rinfo) {
67 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode())); 68 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode()));
68 return rinfo->IsPatchedReturnSequence(); 69 return rinfo->IsPatchedReturnSequence();
69 } 70 }
70 71
71 72
72 bool BreakLocationIterator::IsDebugBreakAtSlot() { 73 bool BreakLocationIterator::IsDebugBreakAtSlot() {
73 ASSERT(IsDebugBreakSlot()); 74 ASSERT(IsDebugBreakSlot());
74 // Check whether the debug break slot instructions have been patched. 75 // Check whether the debug break slot instructions have been patched.
75 return !Assembler::IsNop(rinfo()->pc()); 76 return !Assembler::IsNop(rinfo()->pc());
76 } 77 }
77 78
78 79
79 void BreakLocationIterator::SetDebugBreakAtSlot() { 80 void BreakLocationIterator::SetDebugBreakAtSlot() {
80 ASSERT(IsDebugBreakSlot()); 81 ASSERT(IsDebugBreakSlot());
81 rinfo()->PatchCodeWithCall( 82 rinfo()->PatchCodeWithCall(
82 Debug::debug_break_slot()->entry(), 83 Isolate::Current()->debug()->debug_break_slot()->entry(),
83 Assembler::kDebugBreakSlotLength - Assembler::kCallInstructionLength); 84 Assembler::kDebugBreakSlotLength - Assembler::kCallInstructionLength);
84 } 85 }
85 86
86 87
87 void BreakLocationIterator::ClearDebugBreakAtSlot() { 88 void BreakLocationIterator::ClearDebugBreakAtSlot() {
88 ASSERT(IsDebugBreakSlot()); 89 ASSERT(IsDebugBreakSlot());
89 rinfo()->PatchCode(original_rinfo()->pc(), Assembler::kDebugBreakSlotLength); 90 rinfo()->PatchCode(original_rinfo()->pc(), Assembler::kDebugBreakSlotLength);
90 } 91 }
91 92
92 93
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 308
308 const bool Debug::kFrameDropperSupported = true; 309 const bool Debug::kFrameDropperSupported = true;
309 310
310 #undef __ 311 #undef __
311 312
312 #endif // ENABLE_DEBUGGER_SUPPORT 313 #endif // ENABLE_DEBUGGER_SUPPORT
313 314
314 } } // namespace v8::internal 315 } } // namespace v8::internal
315 316
316 #endif // V8_TARGET_ARCH_X64 317 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/cpu-x64.cc ('k') | src/x64/disasm-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698