Refactor Textfield and AutocompleteEditViewViews.

views/controls/textfield/textfield_controller.h

Index: views/controls/textfield/textfield_controller.h
diff --git a/views/controls/textfield/textfield_controller.h b/views/controls/textfield/textfield_controller.h
index 53fe97cdd4ec37ce78f3d7d059aca7283baeabb2..ee8df1b18b13939ef44164af5e5027357cf876dc 100644
--- a/views/controls/textfield/textfield_controller.h
+++ b/views/controls/textfield/textfield_controller.h
@@ -26,6 +26,17 @@ class TextfieldController {
   // further. If it returns false the processing continues.
   virtual bool HandleKeyEvent(Textfield* sender,
                               const KeyEvent& key_event) = 0;
+
+  // Called before performing a user action that may change the textfield.
+  // It's currently only supported by Views implementation.
+  virtual void OnBeforeUserAction(Textfield* sender) {}
+
+  // Called after performing a user action that may change the textfield.
+  // It's currently only supported by Views implementation.
+  virtual void OnAfterUserAction(Textfield* sender) {}

[oshima, 2011/03/21 21:11:43]

Isn't it feasible to make this pure virtual?

[oshima, 2011/03/22 03:02:28]

how about this?

And related question. I think supporting composition text in findbar is useful.
What do you think?

[James Su, 2011/03/22 04:27:24]

Sorry I missed it. I'd like to make these two methods pure virtual, but I need
to touch lots of files to do it. So I'd rather keep them non-pure virtual for
now. And maybe keeping them non-pure virtual is better, because most of those
TextfieldController implementations don't need them.

[James Su, 2011/03/22 04:27:24]

I personally like it, and it's already supported in my CLs. I remembered that
it's disabled in NativeTextfieldWin because of a bug report, but I didn't
remember the details.

[oshima, 2011/03/22 23:22:23]

In fact, many use of this class has empty impl. It was useful to avoid issue of
renaming method, but since we now has OVERRIDE, may be we can just use {}

It's out of this CL's scope of course.

[oshima, 2011/03/22 23:22:23]

What I meant is to enable search with composition text. I think FindBar needs to
implement OnAfterUserAction, doesn't it? (This is out of scope too.)

[James Su, 2011/03/22 23:49:57]

FindBar implements ContentsChanged(), it should be enough. OnAfterUserAction is
for cases that something other than content was changed, eg. selection range,
composition state, etc.

[oshima, 2011/03/23 18:53:04]

This wasn't working for views/gtk. bit I now see your another change calls
ContentsChagned when composition text is changed. Sweet!

+
+ protected:
+  virtual ~TextfieldController() {}
 };
 
 }  // namespace views