Refactor Textfield and AutocompleteEditViewViews.

views/controls/textfield/native_textfield_views.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_
 #define VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_
 #pragma once
 
 #include "base/string16.h"
 #include "base/task.h"
@@ skipping 151 matching lines @@
   void RepaintCursor();
 
   // Update the cursor_bounds and text_offset.
   void UpdateCursorBoundsAndTextOffset();
 
   void PaintTextAndCursor(gfx::Canvas* canvas);
 
   // Handle the keyevent.
   bool HandleKeyEvent(const KeyEvent& key_event);
 
-  // Utility function. Gets the character corresponding to a keyevent.
-  // Returns 0 if the character is not printable.
-  char16 GetPrintableChar(const KeyEvent& key_event);
-
   // Find a cusor position for given |point| in this views coordinates.
   size_t FindCursorPosition(const gfx::Point& point) const;
 
   // Mouse event handler. Returns true if textfield needs to be repainted.
   bool HandleMousePressed(const views::MouseEvent& e);
 
   // Helper function that sets the cursor position at the location of mouse
   // event.
   void SetCursorForMouseClick(const views::MouseEvent& e);
 
   // Utility function to inform the parent textfield (and its controller if any)
   // that the text in the textfield has changed.
   void PropagateTextChange();
 
   // Does necessary updates when the text and/or the position of the cursor
   // changed.
   void UpdateAfterChange(bool text_changed, bool cursor_changed);
 
   // Utility function to create the context menu if one does not already exist.
   void InitContextMenuIfRequired();
 
+  // Convenience method to call TextfieldController::OnBeforeUserAction();
+  void OnBeforeUserAction();
+
+  // Convenience method to call TextfieldController::OnAfterUserAction();
+  void OnAfterUserAction();
+
+  // Checks if a char is ok to be inserted into the textfield.

[oshima, 2011/03/22 23:22:23]

Can you add comment that ch is modified char?

[James Su, 2011/03/22 23:49:57]

Done.

+  static bool ShouldInsertChar(char16 ch, int flags);
+
   // The parent textfield, the owner of this object.
   Textfield* textfield_;
 
   // The text model.
   scoped_ptr<TextfieldViewsModel> model_;
 
   // The reference to the border class. The object is owned by View::border_.
   TextfieldBorder* text_border_;
 
   // The x offset for the text to be drawn, without insets;
@@ skipping 23 matching lines @@
   // Context menu and its content list for the textfield.
   scoped_ptr<ui::SimpleMenuModel> context_menu_contents_;
   scoped_ptr<Menu2> context_menu_menu_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeTextfieldViews);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_