chrome/test/data/autofill/phone_pinput_autofill.txt - Issue 6685077: Two sets of Autofill tests....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/autofill/phone_pinput_autofill.txt

Issue 6685077: Two sets of Autofill tests.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/automation/testing_automation_provider.cc ('K') | « chrome/test/data/autofill/phone_pexpected_autofill.txt ('k') | chrome/test/functional/autofill.py » ('j') | chrome/test/functional/autofill.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Input profile for comparing phone numbers in Autofill tests.

	2 # Used by: chrome/test/functional/autofill.py testComparePhoneNumbers

	3

	4 [

	5 {'NAME_FIRST': 'Bob', 'NAME_LAST': 'Smith', 'ADDRESS_HOME_LINE1': '1234 H St.',

	6 'ADDRESS_HOME_CITY': 'San Jose', 'ADDRESS_HOME_STATE': 'CA',

	7 'ADDRESS_HOME_ZIP': '95110','PHONE_HOME_WHOLE_NUMBER': '1-408-123-4567',
	dennis_jeffrey 2011/03/25 16:56:14 Is all of this extra spaces at the end of each lin Is all of this extra spaces at the end of each line? If so, the trailing spaces should be deleted. dyu1 2011/03/25 19:10:57 No, there are no extra spaces in this file. I upda Show quoted text On 2011/03/25 16:56:14, dennis_jeffrey wrote: > Is all of this extra spaces at the end of each line? If so, the trailing spaces > should be deleted. No, there are no extra spaces in this file. I updated it again to be sure. dennis_jeffrey 2011/03/25 21:08:45 Ok, just checking. In the previous patch I was lo Show quoted text On 2011/03/25 19:10:57, dyu1 wrote: > On 2011/03/25 16:56:14, dennis_jeffrey wrote: > > Is all of this extra spaces at the end of each line? If so, the trailing > spaces > > should be deleted. > > No, there are no extra spaces in this file. I updated it again to be sure. Ok, just checking. In the previous patch I was looking at in the codereview site, I saw a bunch of green highlights that looked like added spaces at the end of each line. But in the current patch, I don't see them anymore.
	8 'PHONE_HOME_CITY_CODE': '408', 'PHONE_HOME_NUMBER': '123-4567',

	9 'PHONE_HOME_EXT': '88888', 'PHONE_HOME_COUNTRY_CODE': '1',

	10 'PHONE_FAX_WHOLE_NUMBER': '1-650-765-4321', 'PHONE_FAX_CITY_CODE': '650',

	11 'PHONE_FAX_NUMBER': '765-4321', 'PHONE_FAX_EXT': '77777',

	12 'PHONE_FAX_COUNTRY_CODE': '1',},

	13 ]

	14

OLD	NEW