Two sets of Autofill tests....

chrome/test/functional/autofill.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import pickle
 
 import autofill_dataset_converter
+import autofill_dataset_generator
 import pyauto_functional  # Must be imported before pyauto
 import pyauto
 
 
 class AutoFillTest(pyauto.PyUITest):
   """Tests that autofill works correctly"""
 
   def Debug(self):
     """Test method for experimentation.
 
@@ skipping 119 matching lines @@
     js_code = """
       document.getElementById("merge_dup").submit();
       window.addEventListener("unload", function() {
         window.domAutomationController.send("done");
       });
     """
     self.ExecuteJavascript(js_code, 0, 0)
     if 'EMAIL_ADDRESS' in self.GetAutofillProfile()['profiles'][0]:
       raise KeyError('TEST FAIL: Malformed email address is saved in profiles.')
 
+  def testComparePhoneNumbers(self):
+    """Test phone fields parses correctly from a given profile."""
+    profile_path = os.path.join(self.DataDir(), 'autofill',
+                                'phone_pinput_autofill.txt')
+    profile_expected_path = os.path.join(self.DataDir(), 'autofill',
+                                         'phone_pexpected_autofill.txt')
+    profiles = self.EvalDataFrom(profile_path)
+    profiles_expected = self.EvalDataFrom(profile_expected_path)
+    tab_keypress=0x09
+    down_keypress=0x28
+    return_keypress=0x0D

[dennis_jeffrey, 2011/03/18 21:44:01]

I think the above 3 lines are better declared as named constants.

[dyu1, 2011/03/21 18:42:35]

Done.

+    self.FillAutofillProfile(profiles=profiles)
+    url = self.GetHttpURLForDataPath(
+        os.path.join('autofill', 'form_phones.html'))
+    for profile_expected in profiles_expected:
+      self.NavigateToURL(url)
+      self.SendKeyEvent(tab_keypress, windex=0, tab_index=0)

[dennis_jeffrey, 2011/03/18 21:44:01]

Could you add a comment to explain what you're doing with the next 4 key events?

[dyu1, 2011/03/21 18:42:35]

I thought the named variables was self explanatory but I'll add the comments you
suggested.

+      self.SendKeyEvent(down_keypress, windex=0, tab_index=0)
+      self.SendKeyEvent(down_keypress, windex=0, tab_index=0)
+      self.SendKeyEvent(return_keypress, windex=0, tab_index=0)
+      raw_input()

[dennis_jeffrey, 2011/03/18 21:44:01]

This line shouldn't be here in an automated test, right?

[dyu1, 2011/03/21 18:42:35]

Left it in for debugging but removed it in my last revision.

+      form_values = {}
+      for key, value in profile_expected.iteritems():
+        js_returning_field_value = (
+            'var field_value = document.getElementById("%s").value;'
+            'window.domAutomationController.send(field_value);'
+            ) % key
+        form_values[key] = self.ExecuteJavascript(
+            js_returning_field_value, 0, 0)
+        self.assertEqual(
+            form_values[key], value,
+            'Original profile not equal to expected profile at key: "%s" \
+            \nExpected: "%s"\nReturned: "%s"' % (key, value, form_values[key]))

[dennis_jeffrey, 2011/03/18 21:44:01]

Rather than using "\" to continue the string onto the next line, I recommend
enclosing the string in parens and then using implicit line joining:

('Original profile not equal to expected profile at key: "%s"\n'
 'Expected: "%s"\nReturned: "%s"' % (key, value, form_values[key]))

[dyu1, 2011/03/21 18:42:35]

Done.

+
+  def FormFillLatencyAfterSubmit(self):

[dennis_jeffrey, 2011/03/18 21:44:01]

Shouldn't this function name begin with the substring "test"?  Or is this
because the test is only partially automated and you don't want it to execute
along with all the other automated tests?

[dyu1, 2011/03/21 18:42:35]

Since this test is only partially automated I didn't name it test. All tests
that begin with "tests" are automatically run in the continuous build, so this
is treated more as a helper function.

+    """Test latency time on form submit with lots of stored Autofill profiles.
+
+    This test verifies when a profile is selected from the Autofill dictionary,

[dennis_jeffrey, 2011/03/18 21:44:01]

Remove the comma at the end of this line.

[dyu1, 2011/03/21 18:42:35]

Done.

+    that consists of thousands of profiles, the form does not hang after being
+    submitted.
+    """
+    # HTML file needs to be run from a http:// url.
+    url = self.GetHttpURLForDataPath(
+        os.path.join('autofill', 'latency_after_submit_test.html'))
+    # Run the generator script to generate the dictionary list needed for the
+    # profiles.
+    gen = autofill_dataset_generator.DatasetGenerator(
+        logging_level=logging.ERROR)  # Set verbosity to INFO, WARNING, ERROR.
+    list_of_dict = gen.GenerateDataset(num_of_records_to_generate=50)

[dennis_jeffrey, 2011/03/18 21:44:01]

Does this mean you're generating 50 profiles?  The comment for this test says
that it should involve "thousands" of profiles.

[dyu1, 2011/03/21 18:42:35]

Only left 50 for testing purposes. Will change to 1000 when I actually commit.

+    self.FillAutofillProfile(profiles=list_of_dict)
+    tab_keypress=0x09
+    down_keypress=0x28
+    return_keypress=0x0D

[dennis_jeffrey, 2011/03/18 21:44:01]

Perhaps better as constants defined at the top of this file.

[dyu1, 2011/03/21 18:42:35]

Done.

+    self.NavigateToURL(url)
+    self.SendKeyEvent(tab_keypress, windex=0, tab_index=0)

[dennis_jeffrey, 2011/03/18 21:44:01]

Add a comment to describe what this sequence of keypresses is doing.

[dyu1, 2011/03/21 18:42:35]

Done.

+    self.SendKeyEvent(down_keypress, windex=0, tab_index=0)
+    self.SendKeyEvent(down_keypress, windex=0, tab_index=0)
+    self.SendKeyEvent(return_keypress, windex=0, tab_index=0)
+    # Requires manual intervention to test the performance time after submitted

[dennis_jeffrey, 2011/03/18 21:44:01]

"submitted" --> "submitting"

[dyu1, 2011/03/21 18:42:35]

Done.

+    # the form.
+    raw_input()

[dennis_jeffrey, 2011/03/18 21:44:01]

Is it considered acceptable to check in PyAuto tests that require manual
intervention to do the verification?  If so, that's fine, but then let's make it
clear somehow.  We should maybe label such tests with the suffix "_MANUAL", or
at least make this clear in the comment above that describes this function/test.

[dyu1, 2011/03/21 18:42:35]

Yes, should be fine as Nir approved of two other tests that requires manual
intervention. These tests do the bulk of the work that would be tedious to do
manually. The final steps missing are verification steps that can't be done with
what's available. 

+
+
   def AutofillCrowdsourcing(self):
     """Test able to send POST request of web form to Autofill server.
 
     The Autofill server processes the data offline, so it can take a few days
     for the result to be detectable. Manual verification is required.
     """
     # HTML file needs to be run from a specific http:// url to be able to verify
     # the results a few days later by visiting the same url.
     url = 'http://www.corp.google.com/~dyu/autofill/crowdsourcing-test.html'
     # Adding crowdsourcing Autofill profile.
@@ skipping 52 matching lines @@
     merged_profile = os.path.join(self.DataDir(), 'autofill',
                                   'merged-profiles.txt')
     profile_dict = self.GetAutofillProfile()['profiles']
     output = open(merged_profile, 'wb')
     pickle.dump(profile_dict, output)
     output.close()
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()