Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: views/controls/textfield/native_textfield_views.cc

Issue 6685069: Disambiguate OnMouseCaptureLost from OnMouseReleased, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Refinements, etc. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_views.cc
diff --git a/views/controls/textfield/native_textfield_views.cc b/views/controls/textfield/native_textfield_views.cc
index f935193672fc5c5ee9921ad34bc739e431d27a7f..f553f34fb3ee0ab7d8445f8694b8cf4f6f483a43 100644
--- a/views/controls/textfield/native_textfield_views.cc
+++ b/views/controls/textfield/native_textfield_views.cc
@@ -85,14 +85,14 @@ NativeTextfieldViews::~NativeTextfieldViews() {
////////////////////////////////////////////////////////////////////////////////
// NativeTextfieldViews, View overrides:
-bool NativeTextfieldViews::OnMousePressed(const views::MouseEvent& e) {
- if (HandleMousePressed(e))
+bool NativeTextfieldViews::OnMousePressed(const views::MouseEvent& event) {
+ if (HandleMousePressed(event))
SchedulePaint();
return true;
}
-bool NativeTextfieldViews::OnMouseDragged(const views::MouseEvent& e) {
- size_t pos = FindCursorPosition(e.location());
+bool NativeTextfieldViews::OnMouseDragged(const views::MouseEvent& event) {
+ size_t pos = FindCursorPosition(event.location());
if (model_->MoveCursorTo(pos, true)) {
UpdateCursorBoundsAndTextOffset();
SchedulePaint();
@@ -100,18 +100,14 @@ bool NativeTextfieldViews::OnMouseDragged(const views::MouseEvent& e) {
return true;
}
-void NativeTextfieldViews::OnMouseReleased(const views::MouseEvent& e,
- bool canceled) {
-}
-
-bool NativeTextfieldViews::OnKeyPressed(const views::KeyEvent& e) {
+bool NativeTextfieldViews::OnKeyPressed(const views::KeyEvent& event) {
// OnKeyPressed/OnKeyReleased/OnFocus/OnBlur will never be invoked on
// NativeTextfieldViews as it will never gain focus.
NOTREACHED();
return false;
}
-bool NativeTextfieldViews::OnKeyReleased(const views::KeyEvent& e) {
+bool NativeTextfieldViews::OnKeyReleased(const views::KeyEvent& event) {
NOTREACHED();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698