Disambiguate OnMouseCaptureLost from OnMouseReleased, etc.

chrome/browser/ui/views/location_bar/star_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_
 #pragma once
 
 #include "chrome/browser/ui/views/info_bubble.h"
 #include "views/controls/image_view.h"
 
 class CommandUpdater;
 class InfoBubble;
 
 namespace views {
 class KeyEvent;
 class MouseEvent;
 }
 
 class StarView : public views::ImageView, public InfoBubbleDelegate {
  public:
   explicit StarView(CommandUpdater* command_updater);
   virtual ~StarView();
 
   // Toggles the star on or off.
   void SetToggled(bool on);
 
- private:
   // views::ImageView overrides:
+  virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
+  virtual void OnMouseReleased(const views::MouseEvent& event) OVERRIDE;
+  virtual bool OnKeyPressed(const views::KeyEvent& event) OVERRIDE;
+  virtual bool GetTooltipText(const gfx::Point& p,
+                              std::wstring* tooltip) OVERRIDE;
   virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
-  virtual bool GetTooltipText(const gfx::Point& p, std::wstring* tooltip)
-      OVERRIDE;
-  virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE;
-  virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled)
-      OVERRIDE;
-  virtual bool OnKeyPressed(const views::KeyEvent& e) OVERRIDE;
 
   // InfoBubbleDelegate overrides:
   virtual void InfoBubbleClosing(InfoBubble* info_bubble,
                                  bool closed_by_escape) OVERRIDE;
   virtual bool CloseOnEscape() OVERRIDE;
   virtual bool FadeInOnShow() OVERRIDE;
 
+ private:

[sadrul, 2011/03/19 09:15:30]

Why are all the private functions made public?

[msw, 2011/03/26 00:09:50]

Done.

   // The CommandUpdater for the Browser object that owns the location bar.
   CommandUpdater* command_updater_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(StarView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_