Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6685063: Fix glue for ClipboardHostMsg_ReadAvailableTypes. (Closed)

Created:
9 years, 9 months ago by dcheng
Modified:
9 years, 7 months ago
Reviewers:
jam, Dmitry Titov
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix glue for ClipboardHostMsg_ReadAvailableTypes. Since we no longer plan on using this message to service both drags and pasteboard requests, update the glue to call ui::base::Clipboard directly. Eventually, the remaining functions in ClipboardDispatcher will also be moved and/or deleted and the empty class removed. BUG=75237 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78309

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Really fix compile errors. #

Patch Set 5 : Rebase to trunk. #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -36 lines) Patch
M chrome/common/clipboard_messages.h View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 2 3 2 chunks +7 lines, -9 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.cc View 1 2 3 4 3 chunks +4 lines, -6 lines 0 comments Download
M ui/base/clipboard/clipboard.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_linux.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_mac.mm View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_win.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/simple_clipboard_impl.cc View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
9 years, 9 months ago (2011-03-14 20:45:14 UTC) #1
jam
http://codereview.chromium.org/6685063/diff/1/content/browser/renderer_host/clipboard_message_filter.cc File content/browser/renderer_host/clipboard_message_filter.cc (right): http://codereview.chromium.org/6685063/diff/1/content/browser/renderer_host/clipboard_message_filter.cc#newcode146 content/browser/renderer_host/clipboard_message_filter.cc:146: *succeeded = true; // TODO(dcheng): Remove this parameter from ...
9 years, 9 months ago (2011-03-14 20:54:33 UTC) #2
dcheng
http://codereview.chromium.org/6685063/diff/1/content/browser/renderer_host/clipboard_message_filter.cc File content/browser/renderer_host/clipboard_message_filter.cc (right): http://codereview.chromium.org/6685063/diff/1/content/browser/renderer_host/clipboard_message_filter.cc#newcode146 content/browser/renderer_host/clipboard_message_filter.cc:146: *succeeded = true; // TODO(dcheng): Remove this parameter from ...
9 years, 9 months ago (2011-03-14 21:12:49 UTC) #3
dcheng
9 years, 9 months ago (2011-03-15 22:29:37 UTC) #4 
Mind taking another look at this patch set? I plan on landing this once the try
bot returns successfully.

Powered by Google App Engine
This is Rietveld 408576698