Reland again Msysgit Support for gcl and git-cl....

gcl.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 1105 matching lines @@
   else:
     text += ('\n'.join([f[0] + f[1] for f in affected_files]) + '\n' +
             separator2)
   text += '\n'.join([f[0] + f[1] for f in unaffected_files]) + '\n'
 
   handle, filename = tempfile.mkstemp(text=True)
   os.write(handle, text)
   os.close(handle)
 
   # Open up the default editor in the system to get the CL description.
-  result = None
   try:
     if not silent:
-      os.system(GetEditor() + " " + filename)
+      cmd = '%s %s' % (GetEditor(), filename)
+      if sys.platform == 'win32' and os.environ.get('TERM') == 'msys':
+        # Msysgit requires the usage of 'env' to be present.
+        cmd = 'env ' + cmd
+      # shell=True to allow the shell to handle all forms of quotes in $EDITOR.
+      subprocess.check_call(cmd, shell=True)
     result = gclient_utils.FileRead(filename, 'r')
   finally:
     os.remove(filename)
 
   if not result:
     return 0
 
   split_result = result.split(separator1, 1)
   if len(split_result) != 2:
     ErrorExit("Don't modify the text starting with ---!\n\n" + result)
@@ skipping 317 matching lines @@
     if e.code != 500:
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   sys.exit(main(sys.argv[1:]))