Reland again Msysgit Support for gcl and git-cl....

git_cl/git_cl.py

 #!/usr/bin/python
 # git-cl -- a git-command for integrating reviews on Rietveld
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 import errno
 import logging
 import optparse
 import os
 import re
 import StringIO
@@ skipping 693 matching lines @@
 def UserEditedLog(starting_text):
   """Given some starting text, let the user edit it and return the result."""
   editor = os.getenv('EDITOR', 'vi')
 
   (file_handle, filename) = tempfile.mkstemp()
   fileobj = os.fdopen(file_handle, 'w')
   fileobj.write(starting_text)
   fileobj.close()
 
   # Open up the default editor in the system to get the CL description.
-  ret = subprocess.call(editor + ' ' + filename, shell=True)
-  if ret != 0:
+  try:
+    cmd = '%s %s' % (GetEditor(), filename)

[TVL, 2011/03/14 20:53:38]

um, GetEditor() doesn't exist in here, and there is a fetch into editor a few
lines above.

[Mohamed Mansour, 2011/03/14 20:58:17]

Done.

+    if sys.platform == 'win32' and os.environ.get('TERM') == 'msys':
+      # Msysgit requires the usage of 'env' to be present.
+      cmd = 'env ' + cmd
+    # shell=True to allow the shell to handle all forms of quotes in $EDITOR.
+    subprocess.check_call(cmd, shell=True)
+    fileobj = open(filename)
+    text = fileobj.read()
+    fileobj.close()
+  finally:
     os.remove(filename)
-    return
-  fileobj = open(filename)
-  text = fileobj.read()
-  fileobj.close()
 
-  os.remove(filename)
+  if not result:
+    return 0
 
   stripcomment_re = re.compile(r'^#.*$', re.MULTILINE)
   return stripcomment_re.sub('', text).strip()
 
 
 def ConvertToInteger(inputval):
   """Convert a string to integer, but returns either an int or None."""
   try:
     return int(inputval)
   except (TypeError, ValueError):
@@ skipping 675 matching lines @@
             ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))