Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 6685061: Compile the devtools grd file into a .pak file so we (Closed)

Created:
9 years, 9 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Compile the devtools grd file into a .pak file so we can include the data in resources.pak. To avoid resource ids colliding between files, we have a global file, resource_ids, that tracks the starting id values. Since the devtools grd file is generated, it's hard to add an entry to |resource_ids|. To work around this, add support for expanding variables in the |resource_ids|. BUG=35793 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78468

Patch Set 1 #

Patch Set 2 : unittests #

Patch Set 3 : rebase #

Patch Set 4 : rebase and fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M chrome/chrome.gyp View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M tools/grit/grit/grd_reader.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/grit/grit/grd_reader_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/grit/grit/node/misc.py View 1 2 3 4 chunks +31 lines, -2 lines 0 comments Download
M tools/grit/grit/node/misc_unittest.py View 1 1 chunk +14 lines, -0 lines 0 comments Download
M tools/grit/resource_ids View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
This depends on https://bugs.webkit.org/show_bug.cgi?id=56335, which will have to land and be rolled into chromium first. ...
9 years, 9 months ago (2011-03-14 21:20:44 UTC) #1
tony
pfeldman, can you review this? If not, I can try to find someone else (maybe ...
9 years, 9 months ago (2011-03-15 17:41:54 UTC) #2
tony
+mnaganov
9 years, 9 months ago (2011-03-16 18:01:55 UTC) #3
mnaganov (inactive)
9 years, 9 months ago (2011-03-16 18:18:06 UTC) #4
On 2011/03/16 18:01:55, tony wrote:
> +mnaganov

LGTM

Powered by Google App Engine
This is Rietveld 408576698