Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 6685044: Set optimizable to false on code object if shared function info says so.... (Closed)

Created:
9 years, 9 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Set optimizable to false on code object if shared function info says so. Because we might throw away code when doing code flushing we need to set the optimizable flag to false in CompileLaze if this has been set on the shared function info. This is the only place where this can happen, since we always exchange the code with the laze compile stub when doing code flushing. The comment in AbortAndDisable actually states that this is already the case (and that comment should now be ok). Committed: http://code.google.com/p/v8/source/detail?r=7378

Patch Set 1 #

Patch Set 2 : Set optimizable to false on code object if shared function info says so #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/compiler.cc View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 9 months ago (2011-03-14 12:34:14 UTC) #1
Kasper Lund
9 years, 9 months ago (2011-03-14 12:57:43 UTC) #2
LGTM. Is there anyway to assert that we don't have code for a function that is
optimizable when shared->optimization_disabled() is true?

Powered by Google App Engine
This is Rietveld 408576698