Make git_cl pass pylint cleanly

Make git_cl (and everything else not skipped under depot_tools)
pass pylint cleanly. 

There should be no functional changes in this patch, although there's at least one minor bug that lint caught.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78638

[M-A Ruel, 2011-03-13 20:45:48]

http://codereview.chromium.org/6685023/diff/8/gclient_utils.py
File gclient_utils.py (right):

http://codereview.chromium.org/6685023/diff/8/gclient_utils.py#newcode660
gclient_utils.py:660: sys.stdout.flush()
No it's full_flush(), it's defined at line 379.

http://codereview.chromium.org/6685023/diff/8/git-cl
File git-cl (right):

http://codereview.chromium.org/6685023/diff/8/git-cl#newcode8
git-cl:8: # "$base_dir"/update_depot_tools
why?

http://codereview.chromium.org/6685023/diff/8/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6685023/diff/8/git_cl/git_cl.py#newcode1293
git_cl/git_cl.py:1293: # forcing everyone to install simplejson isn't efficient.
We need to change that once git-cl is moved one directory up since simplejson is
included in depot_tools/third_party.

http://codereview.chromium.org/6685023/diff/8/git_cl/git_cl.py#newcode1301
git_cl/git_cl.py:1301: if not json.loads:
We don't need this check anymore.

http://codereview.chromium.org/6685023/diff/8/git_cl/upload.py
File git_cl/upload.py (right):

http://codereview.chromium.org/6685023/diff/8/git_cl/upload.py#newcode57
git_cl/upload.py:57: import readline  # pylint: disable=W0611
Don't modify this file here, you need to modify it upstream in rietveld. For now
just add it to the blacklist.

[Dirk Pranke, 2011-03-14 20:09:33]

On 2011/03/13 20:45:48, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/6685023/diff/8/gclient_utils.py
> File gclient_utils.py (right):
> 
> http://codereview.chromium.org/6685023/diff/8/gclient_utils.py#newcode660
> gclient_utils.py:660: sys.stdout.flush()
> No it's full_flush(), it's defined at line 379.
> 

Ah, sorry. I totally blew that.

> http://codereview.chromium.org/6685023/diff/8/git-cl
> File git-cl (right):
> 
> http://codereview.chromium.org/6685023/diff/8/git-cl#newcode8
> git-cl:8: # "$base_dir"/update_depot_tools
> why?
>

That was a debugging thing that crept in by mistake.
 
> http://codereview.chromium.org/6685023/diff/8/git_cl/git_cl.py
> File git_cl/git_cl.py (right):
> 
> http://codereview.chromium.org/6685023/diff/8/git_cl/git_cl.py#newcode1293
> git_cl/git_cl.py:1293: # forcing everyone to install simplejson isn't
efficient.
> We need to change that once git-cl is moved one directory up since simplejson
is
> included in depot_tools/third_party.
> 

Agreed.

> http://codereview.chromium.org/6685023/diff/8/git_cl/git_cl.py#newcode1301
> git_cl/git_cl.py:1301: if not json.loads:
> We don't need this check anymore.
>

Removed.
 
> http://codereview.chromium.org/6685023/diff/8/git_cl/upload.py
> File git_cl/upload.py (right):
> 
> http://codereview.chromium.org/6685023/diff/8/git_cl/upload.py#newcode57
> git_cl/upload.py:57: import readline  # pylint: disable=W0611
> Don't modify this file here, you need to modify it upstream in rietveld. For
now
> just add it to the blacklist.

Done.

New patch uploaded.

[Dirk Pranke, 2011-03-17 01:26:42]

ping.

[M-A Ruel, 2011-03-17 02:09:09]

lgtm with one nit

http://codereview.chromium.org/6685023/diff/5001/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6685023/diff/5001/git_cl/git_cl.py#newcode1313
git_cl/git_cl.py:1313: except (ImportError):
except ImportError: