Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 6685013: Use IPEndPoint for P2P IPC messages (Closed)

Created:
9 years, 9 months ago by Sergey Ulanov
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Use IPEndPoint for P2P IPC messages BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77923

Patch Set 1 : - #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -131 lines) Patch
M chrome/renderer/p2p/ipc_socket_factory.cc View 6 chunks +18 lines, -17 lines 0 comments Download
M chrome/renderer/p2p/socket_client.h View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/renderer/p2p/socket_client.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/p2p/socket_dispatcher.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/p2p/socket_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p_socket_host.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/p2p_socket_host_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p_socket_host_posix.cc View 4 chunks +22 lines, -53 lines 0 comments Download
M content/browser/renderer_host/p2p_sockets_host.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p_sockets_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
content/common/common_param_traits.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/common/common_param_traits.cc View 1 chunk +19 lines, -0 lines 0 comments Download
content/common/p2p_messages.h View 2 chunks +6 lines, -10 lines 0 comments Download
M content/common/p2p_sockets.h View 1 chunk +0 lines, -10 lines 0 comments Download
D content/common/p2p_sockets.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/ip_endpoint.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/ip_endpoint.cc View 2 chunks +11 lines, -0 lines 1 comment Download
M net/base/ip_endpoint_unittest.cc View 3 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
9 years, 9 months ago (2011-03-11 21:31:22 UTC) #1
jam
does this compile? content shouldn't depend on chrome. so your new ipc paramtraits specialization should ...
9 years, 9 months ago (2011-03-11 23:35:08 UTC) #2
Sergey Ulanov
On 2011/03/11 23:35:08, John Abd-El-Malek wrote: > does this compile? Yes, it does compile. > ...
9 years, 9 months ago (2011-03-12 00:02:02 UTC) #3
jam
lgtm On 2011/03/12 00:02:02, sergeyu wrote: > On 2011/03/11 23:35:08, John Abd-El-Malek wrote: > > ...
9 years, 9 months ago (2011-03-12 00:38:46 UTC) #4
pmarks
9 years, 9 months ago (2011-03-28 01:53:44 UTC) #5
http://codereview.chromium.org/6685013/diff/3001/net/base/ip_endpoint.cc
File net/base/ip_endpoint.cc (right):

http://codereview.chromium.org/6685013/diff/3001/net/base/ip_endpoint.cc#newc...
net/base/ip_endpoint.cc:119: return NetAddressToString(addr, addr_len) + ":" +
base::IntToString(port_);
This looks like it will mangle IPv6 addresses.  Use NetAddressToStringWithPort
instead.

Powered by Google App Engine
This is Rietveld 408576698