Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5874)

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc

Issue 6685008: Cloud print signin crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase past Windows views options removal. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc
diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc
index cebfcb38aad733d31f9208eb98727d46d7fb9bd0..f945e3e004a928053a7669594616f2c95eec5f82 100644
--- a/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc
+++ b/chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc
@@ -45,7 +45,8 @@ static const wchar_t kDoneIframeXPath[] = L"//iframe[@id='setupdone']";
// static
CloudPrintSetupFlow* CloudPrintSetupFlow::OpenDialog(
- Profile* profile, Delegate* delegate, gfx::NativeWindow parent_window) {
+ Profile* profile, const base::WeakPtr<Delegate>& delegate,
+ gfx::NativeWindow parent_window) {
DCHECK(profile);
// Set the arguments for showing the gaia login page.
DictionaryValue args;
@@ -77,10 +78,11 @@ CloudPrintSetupFlow* CloudPrintSetupFlow::OpenDialog(
return flow;
}
-CloudPrintSetupFlow::CloudPrintSetupFlow(const std::string& args,
- Profile* profile,
- Delegate* delegate,
- bool setup_done)
+CloudPrintSetupFlow::CloudPrintSetupFlow(
+ const std::string& args,
+ Profile* profile,
+ const base::WeakPtr<Delegate>& delegate,
+ bool setup_done)
: web_ui_(NULL),
dialog_start_args_(args),
setup_done_(setup_done),

Powered by Google App Engine
This is Rietveld 408576698