Issue 6685008: Cloud print signin crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6685008: Cloud print signin crash. (Closed)

Created:
9 years, 9 months ago by Scott Byer

Modified:
9 years, 7 months ago

Reviewers:
sanjeevr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cloud print signin crash. Found in the Mac crash logs, actually a cross-platform issue, closing the preference tab before finishing setup left a dangling pointer. This CL divorces the lifetimes using a weak pointer. BUG=75647 TEST=Start cloud print setup, close preference tab behind it, finish cloud print setup - no crash! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78054

Patch Set 1 #

Patch Set 2 : Clean up the real lint issues. #

Patch Set 3 : Rebase past Windows views options removal. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -22 lines)			Patch
M	chrome/browser/printing/cloud_print/cloud_print_proxy_service.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_flow.h	View		4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download
A	chrome/browser/printing/cloud_print/cloud_print_setup_handler.h	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	chrome/browser/printing/cloud_print/cloud_print_setup_handler.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/advanced_options_handler.h	View	1 2	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/advanced_options_handler.cc	View	1 2	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages