presubmit_canned_checks.py - Issue 6684026: fix case where an issue may not have any messages yet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 6684026: fix case where an issue may not have any messages yet (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 40df31a59d60bb2bd9f5006f3cf9641652456f0d..ae6ec97608362c94d33750ce1cd903a6ca114c80 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -670,7 +670,7 @@ def _Approvers(input_api, email_regexp):

return email_regexp.match(r) and not input_api.re.match(owner, r)

approvers = []

- for m in issue_props['messages']:

+ for m in issue_props.get('messages', []):

if 'lgtm' in m['text'].lower() and match_reviewer(m['sender']):

approvers.append(m['sender'])

return set(approvers)

« no previous file with comments | « no previous file | no next file » | no next file with comments »