Private API for extensions like ssh-client that need access to TCP.

chrome/browser/extensions/extension_web_proxy_private_api.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_web_proxy_private_api.h"
+
+#include "base/logging.h"
+#include "base/values.h"
+#include "base/string_number_conversions.h"
+#include "chrome/browser/internal_auth.h"
+
+namespace {
+
+// Elaborate this check for future needs.

[Aaron Boodman, 2011/04/06 03:49:00]

The convention is: TODO(<yourusername>): ....

But in this case, I don't think the comment is useful. This TODO could be
applied to any code.

[Denis Lagno, 2011/04/06 18:09:24]

Intention was to express the notion that this function is more like piece of
configuration rather than piece of code.  It configures access restrictions. 
Reformulated.

Oh, I see, problem seems to be in that you probably consider access to
particular private API as atomic piece of permission, so we should not add
additional restrictions depending on extension that uses it..

+bool CheckCredentials(
+    const std::string& extension_id,

[Aaron Boodman, 2011/04/06 03:49:00]

This wrapping is not necessary (the params would fit on less lines).

[Denis Lagno, 2011/04/06 18:09:24]

Done.

+    const std::string& hostname,
+    int port) {
+  int kLowestUnprivelegedPort = 1024;

[Aaron Boodman, 2011/04/06 03:49:00]

const int ...

[Denis Lagno, 2011/04/06 18:09:24]

Done.

+  int kSecureShellPort = 22;
+  return !extension_id.empty() && !hostname.empty() &&

[Aaron Boodman, 2011/04/06 03:49:00]

Kinda weird to pass in extension_id and hostname and then only ensure that they
are non-empty.

The extension system will guarantee that extension_id is always non-empty, there
is no need to check it (everything else will explode if that is not true). If
you are concerned about host_name being non-empty, you can set minLength to 1 in
extension_api.json, and then again, the extension system will guarantee that
before it gets to you.

[Denis Lagno, 2011/04/06 18:09:24]

as I said above, this function is just placeholder for real access restrictions.

Done.

+      (port == kSecureShellPort ||
+          (port >= kLowestUnprivelegedPort && port < (1 << 16)));
+}
+
+}  // namespace
+
+bool WebProxyGetTokenFunction::RunImpl() {
+  std::string hostname;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &hostname));
+  int port;

[Aaron Boodman, 2011/04/06 03:49:00]

Always initialize primitives.

[Denis Lagno, 2011/04/06 18:09:24]

Done.

+  EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(1, &port));
+  std::string id = extension_id();

[zel, 2011/04/05 14:59:25]

const std::string&

[Denis Lagno, 2011/04/06 18:09:24]

Done.

+
+  if (CheckCredentials(id, hostname, port)) {
+    std::map<std::string, std::string> map;
+    map["Hostname"] = hostname;
+    map["Port"] = base::IntToString(port);
+    map["ExtensionId"] = id;
+    StringValue* token = Value::CreateStringValue(
+        browser::InternalAuthGeneration::GenerateToken("WebProxy", map));
+    result_.reset(token);
+  }
+  return true;
+}
+