Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 6683050: Finish conversion of bct_dump to generate config files that cbootimage can parse. (Closed)

Created:
9 years, 9 months ago by robotboy
Modified:
9 years, 7 months ago
Reviewers:
Vincent Palatin
CC:
chromium-os-reviews_chromium.org, pchen, vb, Che-Liang Chiou
Visibility:
Public.

Description

Finish conversion of bct_dump to generate config files that cbootimage can parse. This includes code to look up the human readable string names for enum values. The next step will be to convert all of our existing BCT files from binary to config file format. Then the cros_write_firmware and cros_sign_bootstub tools will need to be changed to read the config file instead of a binary BCT. The tegra-bct ebuilds will also need to change to install config files instead of binary BCT files. BUG=chromium-os:11981 TEST=manually dump a working BCT and run cbootimage to reconstruct the BCT. flash and boot with the new BCT. Change-Id: I056735d0638b349580c6993b2976ca55bf4d0ea2 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=20379c1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -89 lines) Patch
M bct_dump.c View 6 chunks +112 lines, -89 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
robotboy
9 years, 9 months ago (2011-03-14 20:23:21 UTC) #1
Vincent Palatin
9 years, 9 months ago (2011-03-14 21:11:10 UTC) #2
LGTM

Nit: check the whitespaces, they look weird when I download the patch.

http://codereview.chromium.org/6683050/diff/1/bct_dump.c
File bct_dump.c (right):

http://codereview.chromium.org/6683050/diff/1/bct_dump.c#newcode40
bct_dump.c:40: { nvbct_lib_id_block_size_log2,	    "BlockSize     = 0x%08x;\n"
},
I'm seeing mixed tabs and spaces between the 2 columns when looking at the raw
patch.

Powered by Google App Engine
This is Rietveld 408576698