Issue 6683035: Reland Usage of TERM to distinguish between msys and cygwin....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6683035: Reland Usage of TERM to distinguish between msys and cygwin.... (Closed)

Created:
9 years, 9 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
jam, M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Reland Usage of TERM to distinguish between msys and cygwin. BUG=70548 TEST=check $TERM in windows Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77978

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	gcl.py	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	git_cl/git_cl.py	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Mohamed Mansour

I apologize, I should have been more careful with environment variables. Lesson learnt. Somehow in ...

9 years, 9 months ago (2011-03-13 21:40:48 UTC) #1

M-A Ruel

9 years, 9 months ago (2011-03-13 22:19:19 UTC) #2

lgtm, I should have caught that in the last review, sorry.