git_cl/git_cl.py - Issue 6683033: Revert 77954 - Use TERM to distinguish between console and msysgit....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl/git_cl.py

Issue 6683033: Revert 77954 - Use TERM to distinguish between console and msysgit.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl/git_cl.py

===================================================================

--- git_cl/git_cl.py (revision 77971)

+++ git_cl/git_cl.py (working copy)

@@ -712,8 +712,9 @@

# Open up the default editor in the system to get the CL description.

cmd = [editor, filename]

- if sys.platform == 'win32' and os.environ['TERM'] == 'msys':

- # Msysgit requires the usage of 'env' to be present.

+ if sys.platform == 'win32' and 'mingw\\bin' in os.environ['PATH']:

+ # Msysgit requires the usage of 'env' to be present. The only way to

+ # accomplish that is by reading the environment variable for mingw\bin.

cmd.insert(0, 'env')

try:

subprocess.check_call(cmd)

« no previous file with comments | « gcl.py ('k') | no next file » | no next file with comments »