Issue 6683015: Refactor sync notifier out of sync api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6683015: Refactor sync notifier out of sync api (Closed)

Created:
9 years, 9 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Refactor sync notifier out of sync api We now have a clearly defined interface for notifier. Old p2p notifications are still used by tests. Original patch by nileshagrawal@google.com. BUG=75831 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78007

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+549 lines, -331 lines)			Patch
M	chrome/browser/sync/engine/syncapi.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi.cc	View		29 chunks	+73 lines, -235 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_thread.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.h	View		5 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View		4 chunks	+1 line, -6 lines	0 comments	Download
A	chrome/browser/sync/notifier/sync_notifier.h	View		1 chunk	+47 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/notifier/sync_notifier_factory.h	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/notifier/sync_notifier_factory.cc	View	1	1 chunk	+99 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/notifier/sync_notifier_impl.h	View	1	1 chunk	+70 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/notifier/sync_notifier_impl.cc	View	1	1 chunk	+195 lines, -0 lines	0 comments	Download
A	chrome/browser/sync/notifier/sync_notifier_observer.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		5 chunks	+1 line, -67 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Original patch at http://codereview.chromium.org/6621062/