Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 6683014: Change common_message_generator code block. (Closed)

Created:
9 years, 9 months ago by Tom Sepez
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change common_message_generator code block. Makes namespace IPC {} more tightly wrapped around the inclusion of the genertor header file. Updates comments in ipc_message_macros to indicate this new style of block. Makes message ID generation into a macro so can be re-used in forthcoming ipclist CL. Simplfies the NULL macros. Adds #pragma once to param traits, because we can. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77943

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -167 lines) Patch
M chrome/common/common_message_generator.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/common/content_message_generator.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M ipc/ipc_message_macros.h View 11 chunks +27 lines, -17 lines 1 comment Download
M ipc/ipc_message_null_macros.h View 2 chunks +4 lines, -144 lines 0 comments Download
M ipc/param_traits_log_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/param_traits_read_macros.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/param_traits_write_macros.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Sepez
First part of ipclist CL -- parts of message generator code blocks that need to ...
9 years, 9 months ago (2011-03-11 23:02:04 UTC) #1
jam
9 years, 9 months ago (2011-03-11 23:19:53 UTC) #2
lgtm

http://codereview.chromium.org/6683014/diff/1/ipc/ipc_message_macros.h
File ipc/ipc_message_macros.h (right):

http://codereview.chromium.org/6683014/diff/1/ipc/ipc_message_macros.h#newcode38
ipc/ipc_message_macros.h:38: // the following code:
nit: it might be easier for people to copy it if C style comments were used
here.

Powered by Google App Engine
This is Rietveld 408576698