Issue 668259: Add copy constructor and assignment operator to the BitVector class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668259: Add copy constructor and assignment operator to the BitVector class. (Closed)

Created:
10 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add copy constructor and assignment operator to the BitVector class. Committed: http://code.google.com/p/v8/source/detail?r=4063

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -4 lines)			Patch
	M	src/data-flow.h	View		2 chunks	+27 lines, -4 lines	0 comments	Download
	M	test/cctest/test-dataflow.cc	View		1 chunk	+14 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. I'm still concerned about mallocing lots of little arrays, but the problem is no ...

10 years, 9 months ago (2010-03-09 09:38:08 UTC) #2

fschneider

10 years, 9 months ago (2010-03-09 09:51:51 UTC) #3

http://codereview.chromium.org/668259/diff/1/2
File test/cctest/test-dataflow.cc (right):

http://codereview.chromium.org/668259/diff/1/2#newcode66
test/cctest/test-dataflow.cc:66: BitVector w = v;
On 2010/03/09 09:38:10, Kevin Millikin wrote:
> This is not testing the assignment operator.

Done.

Expand Messages | Collapse Messages