Issue 668249: Move apply_locales.py from src/chrome/tools/build/ to src/build/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668249: Move apply_locales.py from src/chrome/tools/build/ to src/build/. (Closed)

Created:
10 years, 9 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move apply_locales.py from src/chrome/tools/build/ to src/build/. src/app shouldn't depend on src/chrome and I need to break these dependencies for some upstreaming work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40985

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -46 lines)			Patch
M	app/app.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	build/apply_locales.py	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/tools/build/apply_locales.py	View		1 chunk	+0 lines, -45 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

TVL

I can't tell from codereview, is this landing as a move and not an add/delete? ...

10 years, 9 months ago (2010-03-08 12:56:21 UTC) #2

tony

10 years, 9 months ago (2010-03-09 02:00:53 UTC) #4

Yes, it's an svn move (I think the + means that it has mergeinfo?  not sure).

Thanks!

http://codereview.chromium.org/668249/diff/1/2
File app/app.gyp (right):

http://codereview.chromium.org/668249/diff/1/2#newcode8
app/app.gyp:8: 'apply_locales_cmd': ['python', '../build/apply_locales.py',],
On 2010/03/08 12:56:21, TVL wrote:
> maybe switch to using <(DEPTH) instead of .. also.

Done.

http://codereview.chromium.org/668249/diff/1/4
File chrome/chrome.gyp (right):

http://codereview.chromium.org/668249/diff/1/4#newcode62
chrome/chrome.gyp:62: 'apply_locales_cmd': ['python',
'../build/apply_locales.py'],
On 2010/03/08 12:56:21, TVL wrote:
> ditto

Done.

Expand Messages | Collapse Messages