Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 6682033: Move plugin messages to content. (Closed)

Created:
9 years, 9 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move plugin messages to content. TBR=tsepez Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78099

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -1137 lines) Patch
M chrome/browser/plugin_data_remover.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/common_param_traits.h View 5 chunks +0 lines, -42 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/plugin_messages.h View 1 chunk +0 lines, -241 lines 0 comments Download
D chrome/common/plugin_messages.cc View 1 chunk +0 lines, -315 lines 0 comments Download
D chrome/common/plugin_messages_internal.h View 1 chunk +0 lines, -444 lines 0 comments Download
M chrome/common/webkit_param_traits.h View 2 chunks +0 lines, -52 lines 0 comments Download
M chrome/plugin/npobject_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/npobject_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/npobject_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_interpose_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/command_buffer_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugin_channel_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome_frame/renderer_glue.cc View 1 2 3 2 chunks +12 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_process_host_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/common/common_param_traits.h View 1 3 chunks +186 lines, -12 lines 0 comments Download
M content/common/common_param_traits.cc View 1 2 2 chunks +106 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
A + content/common/plugin_messages.h View 1 2 3 2 chunks +50 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years, 9 months ago (2011-03-14 19:29:14 UTC) #1
Tom Sepez
LGTM once it links. One thing to try is to preserve a plugin_messages.cc file, so ...
9 years, 9 months ago (2011-03-14 19:58:24 UTC) #2
jam
On 2011/03/14 19:58:24, Tom Sepez wrote: > LGTM once it links. One thing to try ...
9 years, 9 months ago (2011-03-14 20:22:02 UTC) #3
jam
9 years, 9 months ago (2011-03-14 20:29:44 UTC) #4
CCing Ananta: can we add the necessary dependencies on
chrome_frame_unittests?

On Mon, Mar 14, 2011 at 1:22 PM, <jam@chromium.org> wrote:

> On 2011/03/14 19:58:24, Tom Sepez wrote:
>
>> LGTM once it links.  One thing to try is to preserve a plugin_messages.cc
>>
> file,
>
>> so that the chrome_frame_unittests, when it pulls in
>>
> common_message_generator.o
>
>> doesn't have to resolve the plugin dependencies.
>>
>
> I fixed the chrome_frame_unittest linking by adding more functions to
> renderer_glue.cc.  I find how that target links is very fragile.  I don't
> think
> we should make plugin_messages generation more complicated than necessary
> because of this target though.
>
>
> http://codereview.chromium.org/6682033/
>

Powered by Google App Engine
This is Rietveld 408576698