src/x64/assembler-x64.h - Issue 6682026: Fix SmiCompare on 64 bit to distinguish between comparisons where...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.h

Issue 6682026: Fix SmiCompare on 64 bit to distinguish between comparisons where... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64.h

===================================================================

--- src/x64/assembler-x64.h (revision 7153)

+++ src/x64/assembler-x64.h (working copy)

@@ -656,7 +656,7 @@

// Move sign extended immediate to memory location.

void movq(const Operand& dst, Immediate value);

- // New x64 instructions to load a 64-bit immediate into a register.

+ // Instructions to load a 64-bit immediate into a register.

Lasse Reichstein 2011/03/15 09:07:01 Good change. Never name something "new X". It gets

Erik Corry 2011/03/15 10:00:50 yup.

// All 64-bit immediates must have a relocation mode.

void movq(Register dst, void* ptr, RelocInfo::Mode rmode);

void movq(Register dst, int64_t value, RelocInfo::Mode rmode);

@@ -681,7 +681,7 @@

void repmovsl();

void repmovsq();

- // New x64 instruction to load from an immediate 64-bit pointer into RAX.

+ // Instruction to load from an immediate 64-bit pointer into RAX.

void load_rax(void* ptr, RelocInfo::Mode rmode);

void load_rax(ExternalReference ext);

« src/ia32/full-codegen-ia32.cc ('K') | « src/ia32/full-codegen-ia32.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | src/x64/macro-assembler-x64.cc » ('J')