 Chromium Code Reviews
 Chromium Code Reviews Issue 6682026:
  Fix SmiCompare on 64 bit to distinguish between comparisons where...  (Closed) 
  Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
    
  
    Issue 6682026:
  Fix SmiCompare on 64 bit to distinguish between comparisons where...  (Closed) 
  Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/| Index: src/x64/macro-assembler-x64.h | 
| =================================================================== | 
| --- src/x64/macro-assembler-x64.h (revision 7153) | 
| +++ src/x64/macro-assembler-x64.h (working copy) | 
| @@ -278,12 +278,14 @@ | 
| int power); | 
| - // Simple comparison of smis. | 
| - void SmiCompare(Register dst, Register src); | 
| + // Simple comparison of Smis. | 
| 
Lasse Reichstein
2011/03/14 08:51:01
Actually, I believe we try to write "smi" as lower
 
Erik Corry
2011/03/14 16:26:45
Done.
 | 
| void SmiCompare(Register dst, Smi* src); | 
| void SmiCompare(Register dst, const Operand& src); | 
| void SmiCompare(const Operand& dst, Register src); | 
| void SmiCompare(const Operand& dst, Smi* src); | 
| + // Unlike the above these do not assume that the operand or reg contain a Smi. | 
| + void SmiCompareWithObject(Register dst, Smi* src); | 
| + void SmiCompareWithObject(const Operand& dst, Smi* src); | 
| 
Lasse Reichstein
2011/03/14 08:51:01
Rename them to Cmp and group them with the Cmp fun
 
Erik Corry
2011/03/14 16:26:45
Done.
 | 
| // Compare the int32 in src register to the value of the smi stored at dst. | 
| void SmiCompareInteger32(const Operand& dst, Register src); | 
| // Sets sign and zero flags depending on value of smi in register. | 
| @@ -702,6 +704,7 @@ | 
| // Abort execution if argument is not a smi. Used in debug code. | 
| void AbortIfNotSmi(Register object); | 
| + void AbortIfNotSmi(const Operand& object); | 
| // Abort execution if argument is a string. Used in debug code. | 
| void AbortIfNotString(Register object); |