Fix SmiCompare on 64 bit to distinguish between comparisons where...

src/ia32/full-codegen-ia32.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3031 matching lines @@
   Label slow_case;
   Register object = eax;
   Register index_1 = ebx;
   Register index_2 = ecx;
   Register elements = edi;
   Register temp = edx;
   __ mov(object, Operand(esp, 2 * kPointerSize));
   // Fetch the map and check if array is in fast case.
   // Check that object doesn't require security checks and
   // has no indexed interceptor.
-  __ CmpObjectType(object, FIRST_JS_OBJECT_TYPE, temp);
-  __ j(below, &slow_case);
+  __ CmpObjectType(object, JS_OBJECT_TYPE, temp);

[Lasse Reichstein, 2011/03/15 09:07:01]

JS_ARRAY_TYPE

[Erik Corry, 2011/03/15 10:00:50]

Done.

+  __ j(not_equal, &slow_case);
   __ test_b(FieldOperand(temp, Map::kBitFieldOffset),
             KeyedLoadIC::kSlowCaseBitFieldMask);
   __ j(not_zero, &slow_case);
 
   // Check the object's elements are in fast case and writable.
   __ mov(elements, FieldOperand(object, JSObject::kElementsOffset));
   __ cmp(FieldOperand(elements, HeapObject::kMapOffset),
          Immediate(Factory::fixed_array_map()));
   __ j(not_equal, &slow_case);
 
@@ skipping 1195 matching lines @@
   // And return.
   __ ret(0);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32