Fix SmiCompare on 64 bit to distinguish between comparisons where...

src/x64/macro-assembler-x64.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 260 matching lines @@
                                              Register src,
                                              int power);
 
   // Divide a positive smi's integer value by a power of two.
   // Provides result as 32-bit integer value.
   void PositiveSmiDivPowerOfTwoToInteger32(Register dst,
                                            Register src,
                                            int power);
 
 
-  // Simple comparison of smis.
-  void SmiCompare(Register dst, Register src);
+  // Simple comparison of Smis.

[Lasse Reichstein, 2011/03/14 08:51:01]

Actually, I believe we try to write "smi" as lower-case when referring to the
concept, not the Class.

[Erik Corry, 2011/03/14 16:26:45]

Done.

   void SmiCompare(Register dst, Smi* src);
   void SmiCompare(Register dst, const Operand& src);
   void SmiCompare(const Operand& dst, Register src);
   void SmiCompare(const Operand& dst, Smi* src);
+  // Unlike the above these do not assume that the operand or reg contain a Smi.
+  void SmiCompareWithObject(Register dst, Smi* src);
+  void SmiCompareWithObject(const Operand& dst, Smi* src);

[Lasse Reichstein, 2011/03/14 08:51:01]

Rename them to Cmp and group them with the Cmp functions instead.

[Erik Corry, 2011/03/14 16:26:45]

Done.

   // Compare the int32 in src register to the value of the smi stored at dst.
   void SmiCompareInteger32(const Operand& dst, Register src);
   // Sets sign and zero flags depending on value of smi in register.
   void SmiTest(Register src);
 
   // Functions performing a check on a known or potential smi. Returns
   // a condition that is satisfied if the check is successful.
 
   // Is the value a tagged smi.
   Condition CheckSmi(Register src);
@@ skipping 398 matching lines @@
   void FCmp();
 
   // Abort execution if argument is not a number. Used in debug code.
   void AbortIfNotNumber(Register object);
 
   // Abort execution if argument is a smi. Used in debug code.
   void AbortIfSmi(Register object);
 
   // Abort execution if argument is not a smi. Used in debug code.
   void AbortIfNotSmi(Register object);
+  void AbortIfNotSmi(const Operand& object);
 
   // Abort execution if argument is a string. Used in debug code.
   void AbortIfNotString(Register object);
 
   // Abort execution if argument is not the root value with the given index.
   void AbortIfNotRootValue(Register src,
                            Heap::RootListIndex root_value_index,
                            const char* message);
 
   // ---------------------------------------------------------------------------
@@ skipping 1168 matching lines @@
       Jump(adaptor, RelocInfo::CODE_TARGET);
     }
     bind(&invoke);
   }
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_X64_MACRO_ASSEMBLER_X64_H_