Issue 6682024: dynamically generate strides in fmap_find() to cover all of ROM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6682024: dynamically generate strides in fmap_find() to cover all of ROM (Closed)

Created:
9 years, 9 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
dhendrix, Benson Leung

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/flashrom.git@0.11.241.B

Visibility:
Public.

Description

dynamically generate strides in fmap_find() to cover all of ROM This changes the hard coded array of strides to cover with an algorithm that will result in every bit of the ROM being checked. Now the algorithm starts at 1/2 the ROM's total size and divides its stride by 2 on each iteration. BUG= TEST=Tested on Alex with an FMAP structure at various alignments (2M, 1M, 64K, 4K, 16, 5, 1). Review URL: http://codereview.chromium.org/6612048 (cherry picked from commit b0c1154ffda8604e211ce4e8d029b1cbb5d893ac) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=56e829f

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -15 lines)			Patch
	M	fmap.c	View		2 chunks	+37 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2011/03/13 09:34:56, Nick Sanders wrote:

LGTM.

Expand Messages | Collapse Messages