fix prompting if there were errors in the hooks

fix prompting if there were errors in the hooks. Still need to write unit tests.

TBR=maruel@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77922

[M-A Ruel, 2011-03-12 15:37:31]

You forgot to send an email.

post commit lgtm with nits

http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py#newcode785
git_cl/git_cl.py:785: if not res and ('** Presubmit ERRORS **' in
hook_results.output or
with '\n' ?

http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py#newcode796
git_cl/git_cl.py:796: 
remove one extra line.

[Dirk Pranke, 2011-03-12 22:47:47]

http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py#newcode785
git_cl/git_cl.py:785: if not res and ('** Presubmit ERRORS **' in
hook_results.output or
On 2011/03/12 15:37:31, Marc-Antoine Ruel wrote:
> with '\n' ?

I don't understand this comment?

[M-A Ruel, 2011-03-13 00:53:00]

http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py#newcode785
git_cl/git_cl.py:785: if not res and ('** Presubmit ERRORS **' in
hook_results.output or
On 2011/03/12 22:47:47, dpranke wrote:
> On 2011/03/12 15:37:31, Marc-Antoine Ruel wrote:
> > with '\n' ?
> 
> I don't understand this comment? 

I meant to use '** Presubmit ERRORS **\n' so that it's a tad stricter.

[Dirk Pranke, 2011-03-13 01:46:42]

On Sat, Mar 12, 2011 at 4:53 PM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py
> File git_cl/git_cl.py (right):
>
> http://codereview.chromium.org/6682018/diff/2001/git_cl/git_cl.py#newcode785
> git_cl/git_cl.py:785: if not res and ('** Presubmit ERRORS **' in
> hook_results.output or
> On 2011/03/12 22:47:47, dpranke wrote:
>>
>> On 2011/03/12 15:37:31, Marc-Antoine Ruel wrote:
>> > with '\n' ?
>
>> I don't understand this comment?
>
> I meant to use '** Presubmit ERRORS **\n' so that it's a tad stricter.
>

Ah, okay.


> http://codereview.chromium.org/6682018/
>