msm_kgsl: Implement the old version of the KGSL_SHAREDMEM_FROM_PMEM ioctl.

msm_kgsl: Implement the old version of the KGSL_SHAREDMEM_FROM_PMEM ioctl.

BUG=NONE
TEST=Built and run on st1q

[robotboy, 2010-03-05 21:34:07]

LGTM, but msb should probably give it a look as well.

[Mandeep Singh Baines, 2010-03-06 01:01:57]

http://codereview.chromium.org/668184/diff/5/1003
File drivers/char/msm_kgsl/kgsl.c (right):

http://codereview.chromium.org/668184/diff/5/1003#newcode839
drivers/char/msm_kgsl/kgsl.c:839: if ((size == sizeof(struct
kgsl_sharedmem_from_pmem_old) ||
if size is incorrect, we won't report an error and will try to use an all zeros
param.

Maybe just add a separate size check before the copy_from_user check.

if ((size != ...) && (size != ..)) result = -E_INVAL;

[Kenneth Waters, 2010-03-08 18:22:30]

ptal.

http://codereview.chromium.org/668184/diff/5/1003
File drivers/char/msm_kgsl/kgsl.c (right):

http://codereview.chromium.org/668184/diff/5/1003#newcode839
drivers/char/msm_kgsl/kgsl.c:839: if ((size == sizeof(struct
kgsl_sharedmem_from_pmem_old) ||
On 2010/03/06 01:01:57, msb wrote:
> if size is incorrect, we won't report an error and will try to use an all
zeros
> param.
> 
> Maybe just add a separate size check before the copy_from_user check.
> 
> if ((size != ...) && (size != ..)) result = -E_INVAL;

Oops; that was embarrassing.  Done.

[Mandeep Singh Baines, 2010-03-09 20:50:29]

LGTM after fixing minor 80 char nit.

http://codereview.chromium.org/668184/diff/9/10
File drivers/char/msm_kgsl/kgsl.c (right):

http://codereview.chromium.org/668184/diff/9/10#newcode1027
drivers/char/msm_kgsl/kgsl.c:1027: sizeof(struct kgsl_sharedmem_from_pmem));
80 char