Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 668155: Fix stack tweaking in array allocation... (Closed)

Created:
10 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
antonm
CC:
v8-dev
Visibility:
Public.

Description

Fix stack tweaking in array allocation When Array(0) or new Array(0) is handled by the generated code it is handled by the same code as Array() and new Array(). For this to work the stack is tweaked to remove the argument of value 0. However the argc was still passed as 1 if a call to the runtime system was made. When the stack is tweaked argc is also changed to 0. BUG=634 TEST=test/mjsunittest/mjsunit/regress/regress-634.js Committed: http://code.google.com/p/v8/source/detail?r=4038

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M src/ia32/builtins-ia32.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -0 lines 2 comments Download
A test/mjsunit/regress/regress-634.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-05 13:37:55 UTC) #1
antonm
LGTM and thanks a lot for fixing it! http://codereview.chromium.org/668155/diff/1/3 File src/runtime.cc (right): http://codereview.chromium.org/668155/diff/1/3#newcode5733 src/runtime.cc:5733: PrintF("\n"); ...
10 years, 9 months ago (2010-03-05 13:40:38 UTC) #2
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-05 13:42:59 UTC) #3
http://codereview.chromium.org/668155/diff/1/3
File src/runtime.cc (right):

http://codereview.chromium.org/668155/diff/1/3#newcode5733
src/runtime.cc:5733: PrintF("\n");
On 2010/03/05 13:40:38, antonm wrote:
> is it intentional?

Yes, I used %DebugPrint for debugging, and without this newline it looks odd.

Powered by Google App Engine
This is Rietveld 408576698