Issue 668130: Add support for starting NaCl win64 process if nacl64.exe is in the version d...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668130: Add support for starting NaCl win64 process if nacl64.exe is in the version d... (Closed)

Created:
10 years, 9 months ago by gregoryd

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews, native-client-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add support for starting NaCl win64 process if nacl64.exe is in the version directory. We now assume that nacl64.exe is in the same directory as chrome.dll (and not as chrome.exe as we assumed before). BUG=28176 TEST=none Committed: revision 40809

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/nacl_host/nacl_broker_host.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

huanr

http://codereview.chromium.org/668130/diff/5/6 File chrome/browser/nacl_host/nacl_broker_host.cc (right): http://codereview.chromium.org/668130/diff/5/6#newcode53 chrome/browser/nacl_host/nacl_broker_host.cc:53: looks like this code is called in chrome.dll? you ...

10 years, 9 months ago (2010-03-05 18:08:57 UTC) #2

gregoryd

On 2010/03/05 18:08:57, huanr wrote: > http://codereview.chromium.org/668130/diff/5/6 > File chrome/browser/nacl_host/nacl_broker_host.cc (right): > > http://codereview.chromium.org/668130/diff/5/6#newcode53 > ...

10 years, 9 months ago (2010-03-05 20:17:28 UTC) #3

LGTM

Expand Messages | Collapse Messages