Issue 668114: Overinstall mismatch, Launch the existing chrome instead...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 668114: Overinstall mismatch, Launch the existing chrome instead... (Closed)

Created:
10 years, 9 months ago by cpu_(ooo_6.6-7.5)

Modified:
9 years, 7 months ago

Reviewers:
huanr, Mark Larson, Glenn Wilson

CC:
chromium-reviews, kuchhal

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Overinstall mismatch, Launch the existing chrome instead - If the user has a system-level chrome and it is trying to install user level, instead of having omaha show an error, the existing system level install is launched with --first-run - Disable toast experiment BUG=37410 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40701

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -3 lines)			Patch
M	chrome/installer/setup/setup_main.cc	View	1	3 chunks	+27 lines, -2 lines	0 comments	Download
M	chrome/installer/util/browser_distribution.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/util/google_chrome_distribution.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/installer/util/util_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Glenn Wilson

http://codereview.chromium.org/668114/diff/1/3 File chrome/installer/util/util_constants.h (right): http://codereview.chromium.org/668114/diff/1/3#newcode18 chrome/installer/util/util_constants.h:18: EXISTING_VERSION_LAUNCHED, // No work done, just launched existing chrome ...

10 years, 9 months ago (2010-03-05 00:01:00 UTC) #2

cpu_(ooo_6.6-7.5)

Huan made a good observation about the potential of this to affect silent upgrades. Changed ...

10 years, 9 months ago (2010-03-05 00:58:49 UTC) #3

Glenn Wilson

10 years, 9 months ago (2010-03-05 01:15:22 UTC) #5

After discussing the location of the return code in the enum, it's probably ok
where it is.

LGTM

Expand Messages | Collapse Messages