Issue 6681042: AU: Handle inability to get proxy servers from Chrome better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6681042: AU: Handle inability to get proxy servers from Chrome better. (Closed)

Created:
9 years, 9 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr, bdavirro, josafat1

Base URL:
http://git.chromium.org/git/update_engine.git@master

Visibility:
Public.

Description

AU: Handle inability to get proxy servers from Chrome better. Rather than have the proxy resolve fail immediately if Chrome can't be contacted, asynchronously return kNoProxy so that update will continue w/o proxy servers. This makes the new Chrome Browser Proxy Resolver behave like the other proxy resolvers. BUG=chromium-os:13039 TEST=unittest; initctl stop ui; do an update Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=518502a

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix warning #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -55 lines)			Patch
	M	chrome_browser_proxy_resolver.cc	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
	M	chrome_browser_proxy_resolver_unittest.cc	View		5 chunks	+19 lines, -49 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM Just curious: under what conditions Chrome isn't running on the system? http://codereview.chromium.org/6681042/diff/1/chrome_browser_proxy_resolver.cc File chrome_browser_proxy_resolver.cc ...

9 years, 9 months ago (2011-03-14 19:58:10 UTC) #3

adlr

9 years, 9 months ago (2011-03-14 21:20:26 UTC) #4

Thanks, fixed and pushed.

It's pretty rare, admittedly, but Tracy did see once instance of it while
testing. Didn't seem to repro.

Expand Messages | Collapse Messages