Issue 6681040: Prevent memory leak for ChromeContentBrowserClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6681040: Prevent memory leak for ChromeContentBrowserClient. (Closed)

Created:
9 years, 9 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, jam, brettw-cc_chromium.org, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Prevent memory leak for ChromeContentBrowserClient. BUG=none TEST=Memory tests / Heapcheck Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78101

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/test/browser_with_test_window_test.cc	View	1 2	3 chunks	+4 lines, -0 lines	0 comments	Download
	M	content/common/content_client.h	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

Charlie Reis

Second round of memory leak fix. Had to update BrowserWithTestWindowTest to get BrowserCommandsTest et all ...

9 years, 9 months ago (2011-03-14 19:04:59 UTC) #2

Charlie Reis

On 2011/03/14 19:22:51, John Abd-El-Malek wrote: > nit: why not just make ContentClient own the ...

9 years, 9 months ago (2011-03-14 19:35:10 UTC) #4

lgtm