Improve SVN.Revert() again to work better in reverting svn added directories.

Improve SVN.Revert() again to work better in reverting svn added directories.

Revert the order back to deleting then svn revert'ing, which is safer than the
reverse. Document a bit better the behavior.

R=dpranke@chromium.org
BUG=none
TEST=commit queue should die less often


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78224

[Dirk Pranke, 2011-03-14 19:46:05]

LGTM.

http://codereview.chromium.org/6681032/diff/1/scm.py
File scm.py (right):

http://codereview.chromium.org/6681032/diff/1/scm.py#newcode864
scm.py:864: for file_status in SVN.CaptureStatus(repo_root):
I wonder if it makes sense at some point to provide a better abstraction over
CaptureStatus() so that we aren't stuck comparing to a list of individual
characters.

[M-A Ruel, 2011-03-15 13:42:54]

http://codereview.chromium.org/6681032/diff/1/scm.py
File scm.py (right):

http://codereview.chromium.org/6681032/diff/1/scm.py#newcode864
scm.py:864: for file_status in SVN.CaptureStatus(repo_root):
On 2011/03/14 19:46:05, dpranke wrote:
> I wonder if it makes sense at some point to provide a better abstraction over
> CaptureStatus() so that we aren't stuck comparing to a list of individual
> characters.

Agreed.

[commit-bot: I haz the power, 2011-03-15 17:14:30]

Change committed as 78224