Issue 6681019: make unit tests pass on the mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6681019: make unit tests pass on the mac (Closed)

Created:
9 years, 9 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, commit-bot: I haz the power, M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Although there appear to be one or two tests that are flaky on both mac and linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77955

Patch Set 2 : tweak svn configuration to make work on mac #

Total comments: 1

Patch Set 3 : update with better comments #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	tests/fake_repos.py	View	1 2	5 chunks	+21 lines, -1 line	0 comments	Download
	M	tests/gclient_scm_test.py	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/6681019/diff/2001/tests/fake_repos.py File tests/fake_repos.py (right): http://codereview.chromium.org/6681019/diff/2001/tests/fake_repos.py#newcode391 tests/fake_repos.py:391: if sys.platform == 'darwin': ?? What happen otherwise? I'd ...

9 years, 9 months ago (2011-03-12 15:39:17 UTC) #2

Dirk Pranke

I've updated the comments with a better explanation. I'm not sure why mac seems so ...

9 years, 9 months ago (2011-03-13 02:22:14 UTC) #3

Change committed as 77955