CHROMIUM: verity: remove checks for error states

CHROMIUM: verity: remove checks for error states

All entries along the path must be either READY or VERIFIED as per
the contract with the caller. There is a BUG_ON which checks this.

BUG=9752
TEST=Ran tests in verity.git. Ran platform_DMVerityCorruption on H/W.

Change-Id: Ib7d00f9bfc3e55ee236974ed6408c11002e14a41
Signed-off-by: Mandeep Singh Baines <msb@chromium.org>;

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=391ff26

[Will Drewry, 2011-03-11 18:59:09]

LGTM

I've read it over a few times and it still seems to match what was in there.  I
may revisit this again later (but don't block now :)

http://codereview.chromium.org/6681004/diff/1/drivers/md/dm-bht.c
File drivers/md/dm-bht.c (right):

http://codereview.chromium.org/6681004/diff/1/drivers/md/dm-bht.c#newcode701
drivers/md/dm-bht.c:701: BUG_ON(state < DM_BHT_ENTRY_READY);
I'd be inclined to do this as:
if (state < DM_BHT_ENTRY_READY)
  goto broken_contract;

...
  return 0;
broken_contract:
  DMCRIT("verify_path: entry in tree is not in a valid state: ...", ...);
  BUG();
}

But we can wait to see if we really need that data or not later :)  Since the
code stabilized, I haven't had bugs that triggered this in a while.

[Paul T, 2011-03-14 16:10:20]

LGTM