Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: test/cctest/test-serialize.cc

Issue 668060: Don't use strcmp to test heap object pointer equality. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-serialize.cc
===================================================================
--- test/cctest/test-serialize.cc (revision 4014)
+++ test/cctest/test-serialize.cc (working copy)
@@ -481,8 +481,8 @@
i += kSmallFixedArraySize) {
Object* obj = Heap::AllocateFixedArray(kSmallFixedArrayLength);
if (new_last != NULL) {
- CHECK_EQ(reinterpret_cast<char*>(obj),
- reinterpret_cast<char*>(new_last) + kSmallFixedArraySize);
+ CHECK(reinterpret_cast<char*>(obj) ==
+ reinterpret_cast<char*>(new_last) + kSmallFixedArraySize);
}
new_last = obj;
}
@@ -500,8 +500,8 @@
pointer_last = NULL;
}
if (pointer_last != NULL) {
- CHECK_EQ(reinterpret_cast<char*>(obj),
- reinterpret_cast<char*>(pointer_last) + kSmallFixedArraySize);
+ CHECK(reinterpret_cast<char*>(obj) ==
+ reinterpret_cast<char*>(pointer_last) + kSmallFixedArraySize);
}
pointer_last = obj;
}
@@ -517,8 +517,8 @@
data_last = NULL;
}
if (data_last != NULL) {
- CHECK_EQ(reinterpret_cast<char*>(obj),
- reinterpret_cast<char*>(data_last) + kSmallStringSize);
+ CHECK(reinterpret_cast<char*>(obj) ==
+ reinterpret_cast<char*>(data_last) + kSmallStringSize);
}
data_last = obj;
}
@@ -534,8 +534,8 @@
map_last = NULL;
}
if (map_last != NULL) {
- CHECK_EQ(reinterpret_cast<char*>(obj),
- reinterpret_cast<char*>(map_last) + kMapSize);
+ CHECK(reinterpret_cast<char*>(obj) ==
+ reinterpret_cast<char*>(map_last) + kMapSize);
}
map_last = obj;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698