Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 668060: Don't use strcmp to test heap object pointer equality. (Closed)

Created:
10 years, 9 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Don't use strcmp to test heap object pointer equality. Committed: http://code.google.com/p/v8/source/detail?r=4019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M test/cctest/test-serialize.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 9 months ago (2010-03-04 12:17:19 UTC) #1
Erik Corry
10 years, 9 months ago (2010-03-04 12:31:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698